[Bug 479546] Review Request: jailkit - Jailkit limits user accounts to specific files and/or commands

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479546





--- Comment #19 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-03-04 13:01:18 EDT ---
Please provide the whole srpm. I can find any of the patches
mentiones in the spec file nowhere.

Some notes:

* Initscripts convension
  - Please use %_initrddir instead of %_sysconfdir/init.d
   
https://fedoraproject.org/wiki/Packaging/SysVInitScript#Initscripts_on_the_filesystem

  - Please add Requires(post) or so:
   
https://fedoraproject.org/wiki/Packaging/SysVInitScript#Initscripts_in_spec_file_scriptlets

  - Please consider to "condrestart" at %posun

* %changelog
  - I suggest to put one line between each %changelog entry like
-------------------------------------------------------------------
* Sat Jan 25 2009 Patrick Dignan <dignan.patrick at, gmail.com> 2.5-3
- Added 3 patches from Dale Bewley and changed that postun to use sed

* Sat Jan 10 2009 Patrick Dignan <dignan.patrick at, gmail.com> 2.5-2
- Removed INSTALL.txt
- Fixed the doc files
- Removed explicit call to enable Fedora specific compiler options

* Sat Jan 10 2009 Patrick Dignan <dignan.patrick at, gmail.com> 2.5-1
- Initial Fedora build
--------------------------------------------------------------------
    This is useful when using Fedora CVS system.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.