[Bug 481333] Review Request:sugar-update-control - Activity update control panel for Sugar

bugzilla at redhat.com bugzilla at redhat.com
Thu Mar 5 15:49:32 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481333





--- Comment #6 from Rex Dieter <rdieter at math.unl.edu>  2009-03-05 10:49:30 EDT ---
Checked source files and COPYING, seems the license ought to be
License: GPLv2+

%files
%{_datadir}/sugar
looks a bit excessive too, that dir is already owned by 'sugar', maybe
something like this would be an improvement:

%{_datadir}/sugar/data/icons/*
# currently nothing (on f-10 anyway) owns extentions, not sure
# here is the best place, but...
%dir %{_datadir}/sugar/extentions/
%{_datadir}/sugar/extensions/cpsection/


Otherise, the rest of the spec is largely simple and clean...
macros used consistently and correctly.

Address these items:
1.  License
2.  dir ownership

and I'll approve this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list