[Bug 483381] Review Request: metromap - Simple program for finding paths in subway/metro maps

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483381


Alexey Torkhov <atorkhov at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |atorkhov at gmail.com
         AssignedTo|nobody at fedoraproject.org    |atorkhov at gmail.com
               Flag|                            |fedora-review?




--- Comment #1 from Alexey Torkhov <atorkhov at gmail.com>  2009-03-05 14:58:53 EDT ---
- Licensing issues should be cleaned up:

a) There is no indication of GPL version in code or docs at all. (There is no
   indication of license at all, but that's another question).
   As such, License tag should be without version - "GPL+".

b) Maps data was taken from pmetro.nm.ru. And it have the following license in
   Russian language (http://pmetro.nm.ru/License.html):
Данные, использованные в программе, свободны для некоммерческого использования,
а также для GPL проектов.

   My translation:
Data used in program is free for non-commercial use and also for GPL projects.

   That is not very clear situation. Could you query license for data upstream?
   In particular they should tell what are terms for:
   * use
   * modification
   * redistribution

- Source url is wrong. Instead of
http://downloads.sourceforge.net/metromap/metromap-0.1.2.tar.bz2
it should be:
http://downloads.sourceforge.net/metro-map/metromap-0.1.2.tar.bz2

- pygtk2-devel is not required in BuildRequires. It should have pygtk2 in
  Requires instead.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.