[Bug 486760] Review Request: mscore - Music Composition & Notation Software
bugzilla at redhat.com
bugzilla at redhat.com
Sat Mar 7 00:05:42 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=486760
Richard W.M. Jones <rjones at redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #11 from Richard W.M. Jones <rjones at redhat.com> 2009-03-06 19:05:41 EDT ---
This continues the review from comment 7:
+ rpmlint output
I'll let the rpmlint warnings go because this uses the %_font_pkg
macro, so I assume that rpmlint is wrong and the macro is right.
+ package name satisfies the packaging naming guidelines
Consistent with Debian package name.
+ BuildRequires list all build dependencies
Fixed, now builds in Koji.
n/a %find_lang instead of %{_datadir}/locale/*
Qt locale, guidelines doesn't apply.
+ reviewer should build the package in mock
Package now built in Koji.
------------------------------------------------
This package is APPROVED by rjones.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list