[Bug 483451] Review Request: k3guitune - Musical instrument tuner

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483451





--- Comment #3 from David Timms <dtimms at iinet.net.au>  2009-03-07 20:18:11 EDT ---
Oget, thanks for the initial review, updated spec/srpm for perusal at:
http://members.iinet.net.au/~timmsy/k3guitune/k3guitune.spec
http://members.iinet.net.au/~timmsy/k3guitune/k3guitune-1.01-2.fc10.src.rpm

(In reply to comment #1)
> 1. First, replace those links with relative ones. This is all you need to do.
The install part now:
- rm the 3x links
- creates new relative symbolic links

> 2- You need to add BR: alsa-lib-devel. Otherwise alsa support won't be
> compiled.
Done.

> To fix the segfault use this patch:
>    http://www.info-telecom.com/files/k3guitune-1.01-fftw.patch
> which I found in 
>    http://www.kde-apps.org/content/show.php/K3Guitune?content=15358
Patch included.

> 3- Can you fix the k3guitune-desktop-file.patch accordingly then?
OK, I've got that sorted now, the icon is displayed.

> Other than these, can you explain (as comments in the SPEC file) what the
> patches do and give links from the upstream tracking system?
Done.

> Also, where does the xpm file come from?
An earlier version of guitune, also GPL. Noted along side the patch definition.
=====
In running with debuginfo inside gdb:
$ gdb k3guitune
GNU gdb Fedora (6.8-29.fc10)
Copyright (C) 2008 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "i386-redhat-linux-gnu"...
(gdb) r
Starting program: /usr/bin/k3guitune 
shell-init: error retrieving current directory: getcwd: cannot access parent
directories: No such file or directory
[Thread debugging using libthread_db enabled]
[New Thread 0xb7fd3700 (LWP 10675)]
Detaching after fork from child process 10682.
shell-init: error retrieving current directory: getcwd: cannot access parent
directories: No such file or directory
kbuildsycoca running...
Couldn't initialize Arts: can't connect to aRts soundserver
[New Thread 0xb3d32b90 (LWP 10710)]
ALSA audio initialized succesfully
Audio driver initialized
[Thread 0xb3d32b90 (LWP 10710) exited]

Program exited normally.
(gdb) q
==
Is the shell-init - cannot access parent directories an issue ?

=====
In running from the command line:
$ k3guitune
Couldn't initialize Arts: can't connect to aRts soundserver
ALSA audio initialized succesfully
Audio driver initialized
==
It seems to take a few seconds to start up (for such a small program), even
after it has just been running. Would it be worth trying to disable
detection/connection to arts ?

=====
I noticed that configure has a look for bio2jack's presence. Would it be OK, to
have a single version that is both alsa (which shows up, and record level
control can be controlled in the pulseaudio volume control) and jack enabled,
or would it be better to package it built for jack separately ?

I haven't looked in detail at what would be involved, it works for me as is,
and would make it easier for Fedora music enthusiasts (who don't know/want to
mess with the intricacies of jack) to use the tuner.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.