[Bug 489233] Review Request: rmol - C++ Revenue Management Optimisation Library (RMOL)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=489233





--- Comment #1 from Jason Tibbitts <tibbs at math.uh.edu>  2009-03-08 18:45:41 EDT ---
I haven't done a full review, but here are a couple of comments:

Please don't define %version and %release like that; if you have
  Version: 0.18.0
then %version is automatically defined for you to 0.18.0.

LGPL is not a valid license tag in Fedora.  Please see
http://fedoraproject.org/wiki/Licensing.  I did not look at the source to see
the license in use, but if it's LGPL version 2 or later, use LGPLv2+.

Please do not use the Vendor or Distribution tags.

0.dev.1 is not a valid value for the Release tag.  If the package is a released
tarball with version 0.18.0, use a positive integer for the release tag with
%{?dist} appended.  (Use of the dist tag is not mandatory but is recommended
unless you are experienced with Fedora packaging and understand how to manage
proper upgrade paths.)  If 0.18.0 has not been released and you're a using some
sort of snapshot leading up to that release then other formats are allowable. 
Please see http://fedoraproject.org/wiki/Packaging/NamingGuidelines for the
full details.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.