[Bug 489337] Review Request: leonidas-backgrounds - Leonidas desktop backgrounds

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=489337





--- Comment #2 from Martin Sourada <martin.sourada at gmail.com>  2009-03-09 15:49:32 EDT ---
(In reply to comment #1)
> Is there a canonical upstream source for the tarball besides this package?  If
> so, could you make Source0: be a full URL to it, or provide (in comments)
> instructions for generating that tarball?  And if this is the canonical source,
> please indicate that in the spec.
> 
Added a comment the that the canonical source is only in the srpm and a short
notice how to get the images within the source tarbal.

> Note to anyone else looking: /usr/share/backgrounds is provided by filesystem
> in F11, so it's not left unowned.
> 
> However, it looks like /usr/share/gnome-background-properties is unowned.  I'm
> not really sure what to do about it; several other *-backgrounds packages own
> it, so it wouldn't be unreasonable for this package to own it as well.
> 
Somehow skipped my attention, I've checked only the /usr/share/backgrounds for
some reason... This package now owns it as well.

> FYI, "cp -a" implies "-r".
> 
Thanks, removed the superfluous -r.

> X can't compare source files against upstream.
See above

> ? latest version is being packaged.
Its a version approved by the art team lead (Máirín Duffy)

> X /usr/share/gnome-background-properties is unowned.
See above

New SPEC:
http://mso.fedorapeople.org/packages/rawhide/SPECS/leonidas-backgrounds.spec
New SRPM:
http://mso.fedorapeople.org/packages/rawhide/SRPMS/leonidas-backgrounds-10.92.1-2.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.