[Bug 488359] Review Request: dcbd - daemon and configuration tool for data center bridging

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488359





--- Comment #10 from Dan Horák <dan at danny.cz>  2009-03-11 04:59:27 EDT ---
formal review is here, see the notes below:

OK source files match upstream:
     2f67e0c17ffef6fbc3de67234a6eb42cd281f449  dcbd-0.9.7.tar.gz
OK package meets naming and versioning guidelines.
OK* specfile is properly named, is cleanly written and uses macros
consistently.
OK dist tag is present.
OK license field matches the actual license.
OK license is open source-compatible (GPLv2). License text included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
BAD rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK correct scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.

- use plain dcbd.spec in the "Updated SPEC" URL
- rpmlint complains a bit:
dcbd.x86_64: W: service-default-enabled /etc/rc.d/init.d/dcbd
dcbd.x86_64: W: service-default-enabled /etc/rc.d/init.d/dcbd
    both in chkconfig and LSB sections
dcbd.x86_64: E: missing-mandatory-lsb-keyword Short-Description in
/etc/rc.d/init.d/dcbd
 => https://fedoraproject.org/wiki/Packaging/SysVInitScript

- non-standard dir (/etc/sysconfig/dcbd/) is used for application config files

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.