[Bug 489686] Review Request: Armadillo - fast C++ matrix library with interfaces to LAPACK and ATLAS

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=489686


Ralf Corsepius <rc040203 at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203 at freenet.de




--- Comment #1 from Ralf Corsepius <rc040203 at freenet.de>  2009-03-11 12:18:21 EDT ---
This submission has several issues:

a) Package doesn't honor %{_libdir} (it installs its lib's to /usr/lib on
x86_64)

b) Please read (closely related to a))
https://fedoraproject.org/wiki/Packaging:Cmake

c) Split the package into a run-time package and a *-devel package

d) Many of the BuildRequires are redundant (BR: *-devel normally automatically
pulls in the corresponding run-time packages)

e) This construct:
[ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT
is being frowned upon in Fedora.

Please use
rm -rf $RPM_BUILD_ROOT
instead

f) Whether a separate *-doc package is necessary/useful is arguable.
Technically, there is no need to have one.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.