[Bug 488124] Review Request: gnubik - 3D interactive graphics puzzle

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488124





--- Comment #5 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com>  2009-03-11 16:28:08 EDT ---
Okay, here's the rest of the full review: (* = blockers, ! = suggestions)

* The Release field in the above SPEC file is incorrect.

! Please expand the description to 80 columns.

* Please remove the binary .gmo files in %prep

! It would probably better to build the .info file from source with something
like
   makeinfo doc/gnubik.texinfo
Note that this will need adding texinfo to BuildRequries.

! The BRs: libX11-devel mesa-libGL-devel mesa-libGLU-devel gtk2-devel are not
necessary. They will be pulled up by gtkglext-devel.
(Side note: When we really need to BR mesa-libGL-devel or mesa-libGLU-devel, we
should BR the virtual provides' libGL-devel libGLU-devel. But as I said above,
this is unnecessay for this package)

! The explicit Requires: hicolor-icon-theme is not necessary. It will be
automatically picked up by dependency chain.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.