[Bug 489803] Review Request: libserial - C++ library to access serial ports on POSIX systems
bugzilla at redhat.com
bugzilla at redhat.com
Thu Mar 12 05:16:56 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=489803
Ralf Corsepius <rc040203 at freenet.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rc040203 at freenet.de
--- Comment #3 from Ralf Corsepius <rc040203 at freenet.de> 2009-03-12 01:16:55 EDT ---
Some comments (leaving a formal review to Kevin):
- BR: gzip and BR: libtool are superfluous
Please remove them.
- Explicitly gzip'ing man-pages is a mistake.
rpm automatically compresses man-pages to the compression format _it_ prefers
by itself.
Please remove the gzip ../man/.. line
- Package installs a man3 man-page called "todo.3"
This is a) too general and b) hardly useful.
Please remove this man-page.
- Fedora specs are supposed not to set Vendor:
Please remove this.
- I for one prefer packages which encapsulate their headers in a
package-specific subdir of /usr/include, instead to put them directly into
/usr/include.
=> Proposal: Install the headers into /usr/include/libserial
(%configure ... --includedir=%{_includedir}/libserial)
[Note: This is just my personal preference and is not a must.]
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list