[Bug 480999] Review Request: python-webflash - Portable flash messages for WSGI apps

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480999


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review?




--- Comment #1 from Jason Tibbitts <tibbs at math.uh.edu>  2009-03-12 01:28:10 EDT ---
Builds fine; rpmlint says:
  python-webflash.noarch: W: no-documentation
True, and not a problem.

  python-webflash.noarch: W: incoherent-version-in-changelog 0.1-0.1a8 
   ['0.1-0.1.a8.fc11', '0.1-0.1.a8']
I think there's a period missing from the changelog version between "1" and
"a8".  Not a huge deal but good to fix.

Does the test suite actually do anything?  I just get:
  nose.plugins.cover: ERROR: Coverage not available: unable to import coverage 
   module
I'm not that familiar with python tests so I could use a hint here.


* source files match upstream.  sha256sum:
   1fe890b93fd0d06b7c6fb95cce46337e51e6bacd6ed52aaed09ac8bd52126c5e  
   WebFlash-0.1a8.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
X rpmlint has a valid complaint.
* final provides and requires are sane:
   python-webflash = 0.1-0.1.a8.fc11
  =
   python(abi) = 2.6
   python-simplejson

? %check is present but I'm completely unsure of whether it's doing anything.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.