[Bug 273701] Review Request: gnome-main-menu - Gnome Main Menu

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=273701





--- Comment #68 from Jeffrey Goh <fedora at linux.com.sg>  2009-03-12 13:19:33 EDT ---
repackaging as per Comment #67, and with reference to:

http://fedoraproject.org/wiki/PackagingGuidelines#Packaging_Guidelines

Vendor/Packager removed (as per #67 above)

"# The Packager tag should not be used in spec files. The identities of the
packagers are evident from the changelog entries. By not using the Packager
tag, you also avoid seeing bad binaries rebuilt by someone else with your name
in the header. See also the Maximum RPM definition of the Packager tag at
www.rpm.org . If you need to include information about the packager in the rpms
you built, use %packager in your ~/.rpmmacros instead.
# The Vendor tag should not be used. It is set automatically by the build
system."

BuildRequires one per line (done)

Rediscovered BuildRequires via rpmdev-rmdevelrpms

re #67: %{datadir}/applications/* -

/usr/share/applications/application-browser.desktop
/usr/share/applications/gnome-screensaver-lock.desktop
/usr/share/applications/gnome-session-logout.desktop
/usr/share/applications/gnome-session-shutdown.desktop
/usr/share/applications/trigger-panel-run-dialog.desktop

re #67: unowned directories problem - fixed, but with "...slab/" instead of
"...slab" as suggested by Dominik

from https://fedoraproject.org/wiki/Packaging/UnownedDirectories

 %{_datadir}/foo/*

This includes everything _in_ "foo", but not "foo" itself. "rpm -qlv pkgname"
will show a missing drwxr-xr-x entry for "foo". Correct would be:

 %{_datadir}/foo/

to include the directory _and_ the entire tree below it. 


=========== updated package fixing spec file only, no need to update unless
you're interested in rebuilding, I guess

Follow instructions here:
http://www.linux.com.sg/fedora10/gnome-main-menu/0.9.12-5/index.html


src-rpm/spec
============

http://www.linux.com.sg/fedora10/gnome-main-menu/0.9.12-5/gnome-main-menu-0.9.12-5.src.rpm 
http://www.linux.com.sg/fedora10/gnome-main-menu/0.9.12-5/gnome-main-menu.spec

x86_64 RPMS
===========

http://www.linux.com.sg/fedora10/gnome-main-menu/0.9.12-5/gnome-main-menu-0.9.12-5.x86_64.rpm 
http://www.linux.com.sg/fedora10/gnome-main-menu/0.9.12-5/gnome-main-menu-debuginfo-0.9.12-5.x86_64.rpm 
http://www.linux.com.sg/fedora10/gnome-main-menu/0.9.12-5/gnome-main-menu-devel-0.9.12-5.x86_64.rpm

i386
http://www.linux.com.sg/fedora10/gnome-main-menu/0.9.12-5/gnome-main-menu-0.9.12-5.i386.rpm 
http://www.linux.com.sg/fedora10/gnome-main-menu/0.9.12-5/gnome-main-menu-debuginfo-0.9.12-5.i386.rpm 
http://www.linux.com.sg/fedora10/gnome-main-menu/0.9.12-5/gnome-main-menu-devel-0.9.12-5.i386.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.