[Bug 453422] Review Request: songbird - Mozilla based multimedia player

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453422





--- Comment #30 from David Halik <auralvance at gmail.com>  2009-03-12 15:28:46 EDT ---

Songbird 1.1.1 stable is now out and the srpm has been updated accordingly. I
very happy with the progress of the package so far thanks to everyone's help. I
think all of the issues that were raised have been addressed. I'm going to post
the spec and srpm as soon as a few issues are worked out. There seems to be a
xulrunner bug when building under F11 which might need a patch. There is also a
hanging issue that is effecting Songbird *NIX users and we're debugging it.
Initial guessing points to the latest gstreamer patches from Songbird that
aren't in the system libraries yet.

(In reply to comment #29)
> Well, since there is a 1.1 beta2 release two days ago, I wonder if it wouldn't
> be suitable to concentrate a this 1.1 pre-release while targeting Fedora-11.
> That would be easier to have fix merged if any.

Beginning with this release I'll targert F11 as suggested.

> Just a quick notes,(don't update the spec just for this at this time):
> Uses Source0:  instead of Source:

Done.

> While using desktop-file-install, please don't use "fedora" as vendor leaving
> it empty ("") for now.

Done.

> Use cp -p to prevent timestamps changes while copying various files/directory. 

Done.

> 
> Don't hardcode the parallel build macro:

Done.

> 
> %post and %postun. Are you really sure you need to run ldconfig at %post and
> %postun (thunderbird doesn't do that at least). 

I did some researching and you're correct. Since we're not sharing out any
libraries ldconfig is not necessary. Removed.

> you should try to use GTK+ icon cache (with various icons size if
> possible) and avoid using the pixmap directory.

Done. I followed the Thunderbird example which also seems to be correct for
Songbird. One thing I wanted to note, I spoke with stevel and opened an
enhancement bug for the icons. Right now they have very few png's included with
the upstreamed tarball, but it's a trivial matter to add a few more. Songbird
bugzilla 15652

> Please use "|| :" to avoid scriplet failure if something went wrong for any
> reason.

Done.

> Do you really need "BuildRequires: zip" ? I guess this is a compression
> utility. You shouldn't need it to decompress anything, aren't you ?
> Unless it is used within the buildsystem... I haven't checked yet.

Unfortunately, xulrunner's autoconfig requires zip or it dies, so I'm leaving
it in for now:

checking for zip... no
configure: error: zip not found in $PATH

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.