[Bug 489564] Review Request: Blueman - Bluetooth Manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=489564





--- Comment #6 from Christian Krause <chkr at plauener.de>  2009-03-12 16:34:01 EDT ---
Hi,

thanks for the new package, I've looked at it and here are some more comments:

- it's good that you've corrected the URL for Source0

- however, the blueman-1.02.tar.gz which is included in your src.rpm does not
match the file provided upstream:

md5sum blueman-1.02.tar.gz SOURCES/blueman-1.02.tar.gz
7f66f569a716f8c6fce9360176166eac  upstream/blueman-1.02.tar.gz
8e02d7d66b46a7c62b4396080aba0211  SOURCES/blueman-1.02.tar.gz

Please use exactly the upstream package. In general all modifications must be
done using patches. (Sure, there are exceptions, e.g. if upstream contains
material which Fedora may not distribute, but that's not the case here).

- rpmlint:
rpmlint SPECS/blueman.spec RPMS/i386/blueman-*
SRPMS/blueman-1.02-4.fc10.src.rpm 
blueman.i386: W: devel-file-in-non-devel-package
/usr/lib/python2.5/site-packages/_blueman.a
3 packages and 1 specfiles checked; 0 errors, 1 warnings.

Looks much better!

The remaining *.a file can be just deleted in the %install section with:
rm -f $RPM_BUILD_ROOT%{_libdir}/python*/site-packages/*.a .

- License: Just a minor issue: Since the source files states that the license
is "gplv3 ... or any later version", please use GPLv3+ in the license tag. ;-)

- wildcard usage: Even this is not a realy mistake, in general please use also
wildcards for the executables and the manuals: %{_bindir}/* and
%{_mandir}/man1/*

- roughly check of the build requirements:
* please substitute gtk2 with gtk2-devel
* please add dbus-python-devel

- mock build problems:
I've played a little bit with mock and your package, and it looks like that
there were just the mentioned build requires missing. It would be good if you
could do the tests on your side, too. What are the issues you've seen so far?
Probably I can help...


Regards,
Christian

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.