[Bug 487737] Review Request: slock - Simple X display locker

bugzilla at redhat.com bugzilla at redhat.com
Sun Mar 15 21:08:39 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487737


Alexey Torkhov <atorkhov at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |atorkhov at gmail.com
               Flag|                            |fedora-review?




--- Comment #5 from Alexey Torkhov <atorkhov at gmail.com>  2009-03-15 17:08:39 EDT ---
- Replace two seds with a patch. It will be easier to read. Moreover, if
upstream decide to change flags in makefile in future, sed will silently
continue with old values and patch will fail.

- This is a GUI application, you should create .desktop file for it. See
https://fedoraproject.org/wiki/Packaging/Guidelines#desktop

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list