[Bug 484331] Review Request: perl-Sendmail-PMilter - Perl binding of Sendmail Milter protocol

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484331





--- Comment #5 from John Guthrie <guthrie at counterexample.org>  2009-03-16 16:42:59 EDT ---
(In reply to comment #3)
> ======
> Notes
> ======
> 1. Soon after your review request was filed, version 0.97 was published. Could
> you please upgrade your package, too ?

Done.

> 2. For consistency sake, I suggest to replace the /usr/bin/ from sed (in %prep)
> with the %bindir macro. I will not block review if you prefer to leave it as it
> is

I'm a little confused.  The sed in the spec file should have been bare.  It
shouldn't have had a /usr/bin in front of it.  Also, sed seems to be in /bin,
not /usr/bin, which is the value of %{_bindir}, IIRC.  Most of my other
commands were bare, so I left the sed bare as well, since it should be in the
path.

> =====
> Issues
> =====
> 1. There is a missing BR for perl(Test::More) which causes mock build to fail.

This has been fixed.

> Please submit a corrected package and I'll gladly approve it if it's OK.  

Here is the new URL for the updated SRPM:
http://www.guthrie.info/RPMS/f10/perl-Sendmail-PMilter-0.97-1.f10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.