[Bug 473037] Review Request: tinycc - Tiny C Compiler
bugzilla at redhat.com
bugzilla at redhat.com
Tue Mar 17 14:07:10 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=473037
Lubomir Rintel <lkundrak at v3.sk> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lkundrak at v3.sk
AssignedTo|nobody at fedoraproject.org |lkundrak at v3.sk
Flag| |fedora-review?
--- Comment #19 from Lubomir Rintel <lkundrak at v3.sk> 2009-03-17 10:07:08 EDT ---
1.) devel subpackage
Why does this have a devel subpackage, and not just everything in one package?
I'd say compilers are used exclusively for development.
2.) You don't install shared libraries
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
This is not needed
3.) License
Most files are LGPLv2+, libtcc1.c is GPLv2+ with linking exception. Therefore
the right license tag should probably be:
License: LGPLv2+ and GPLv2+ with exceptions
4.) libtcc
(In reply to comment #18)
[...]
> IMO, this begs for more questions:
> * Is /usr/lib/libtcc.a located correctly?
> Should it be a generally applicable library (e.g. usable by GCC compiled files)
> then this location is likely correct.
>
> * Is /usr/include/libtcc.h located correctly?
> I doubt it. IMO, it should be a tcc internal header, tcc should implicitly pull
> in interally from some internal include file search path.
libtcc is not used internally. It's a compiler library that allows you to embed
C compiler in your programs.
Therefore libtcc should be compiled dynamically, not statically. Also,
guidelines for -devel packages would apply here.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list