[Bug 490318] Review Request: frescobaldi - Edit LilyPond sheet music with ease!
bugzilla at redhat.com
bugzilla at redhat.com
Tue Mar 17 22:27:07 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=490318
--- Comment #3 from Christian Krause <chkr at plauener.de> 2009-03-17 18:27:04 EDT ---
Here now the complete review. As far as I can see there are just some very
minor issues.
* naming: OK
* spec filename: OK
* License: TODO
- actual license matches License field
- probably "Public Domain" could be added to the License field, too
- License field packaged
* sources: OK
- matches upstream:
e06055e2300a3705daf7895953042f3e frescobaldi-0.7.7.tar.gz
- spectool -g works
* rpmlint: OK
rpmlint SPECS/frescobaldi.spec RPMS/noarch/frescobaldi-0.7.7-1.noarch.rpm
SRPMS/frescobaldi-0.7.7-1.src.rpm
frescobaldi.noarch: W: dangling-relative-symlink
/usr/share/doc/HTML/en/frescobaldi/common ../common
2 packages and 1 specfiles checked; 0 errors, 1 warnings.
The error is a false positive, since the linked target is owned by
kdelibs-common which is required by kdelibs which is required by kdebase-libs
which is required by kdebase which is a direct requirement. ;-)
* dependencies: note: the package needs "rumor" for proper installation
* package builds locally: OK
* package builds in mock: OK
* package builds for F9, F10 and F11: OK
* build requirements: TODO
- probably dbus-python and gettext can be ommited (builds fine without these
tools)
* locale handling: OK
* no dynamic libs
* directory ownership: OK
- owns all directories it creates or requires the owners
* files not listed twice: OK
* permissions: OK, %defattr used
* clean section: OK
* macros consistently used: OK
* code vs. content: OK (besides some icons, no content)
* large documentation in -doc subpackage: OK (n/a, documentation about 230kB)
* *.la files, pkgconfig, static libs, headers, shared libs: OK (n/a, noarch
package)
* .desktop file: TODO
- desktop file exists
- however, there is no entry in the menu when running gnome; I would suggest
adding the gnome category
* rm -rf in %install: OK
* scriptlets: OK
- update-desktop-database called, since .desktop contains MimeType key
- correctly not in Requires(post) according to:
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database
- gtk-update-icon-cache called correctly
* filenames UTF8: OK (rpmlint did not complain)
* final Requires: OK
/bin/sh
/usr/bin/python2.5
PyKDE4
alsa-utils
kdebase
kdegraphics
kdesdk
lilypond
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PartialHardlinkSets) <= 4.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rumor
timidity++
* functional test: OK
- basic functions work
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list