[Bug 490576] Review Request: bibtex2html - Collection of tools for translating from BibTeX to HTML

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490576


Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jussi.lehtola at iki.fi
         AssignedTo|nobody at fedoraproject.org    |jussi.lehtola at iki.fi
               Flag|                            |fedora-review?




--- Comment #1 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-03-17 19:32:28 EDT ---
I can do the review on this one.

A few quick notes:

- change all of the %define:s to %global:s since the behaviour is going to
change shortly (defines are only meant to be local definitions according to RPM
specifications).

- Why do you turn off building of the debug package? Add a comment on this to
the spec file.

- You need to preserve time stamps while copying: change all 'cp' to 'cp -p'.

- Man pages should not be in %doc; remove the %{doc} prefix from the files
section for the man pages. Also, you might want to shorten the whole thing to
just
%{_mandir}/man1/*.1.gz

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.