[Bug 489803] Review Request: libserial - C++ library to access serial ports on POSIX systems
bugzilla at redhat.com
bugzilla at redhat.com
Wed Mar 18 10:49:50 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=489803
--- Comment #10 from Alex Orlandi <nyrk71 at gmail.com> 2009-03-18 06:49:46 EDT ---
(In reply to comment #8)
> OK - Package meets naming and packaging guidelines
> [...cut..]
> Issues:
>
> 1. It's not entirely clear what the license should be here. ;)
> Some of the source files have:
> "Copyright: See COPYING file that comes with this distribution"
> which in fedora implies the License tag should be "GPL+"
> SerialPort.cpp and SerialPort.h say GPLv2+
>
> It's probibly best to talk to upstream and add a header to all the
> source files with their intended license.
I talked to upstream that says:
"Thanks for pointing out the licensing issue. The original intention was to
use GPLv2. I will fix the headers in the file as soon as I return so they
are consistent with GPLv2. However, please feel free to patch the files for
Fedora as you find fit to make them appear as distributed under GPLv2"
> 2. Non blocker, but there are some doxygen warnings you might
> want to mention to upsteam:
>
> Warning: Tag `CGI_NAME' at line 573 of file doxygen.conf has become obsolete.
> To avoid this warning please update your configuration file using "doxygen -u"
> ...(and a few more)
I'll try to patch it in the next spec file; in the meanwhile I notify the
warnings to upstream.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list