[Bug 490562] Review Request: renameutils - A set of programs to make renaming of files easier

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490562





--- Comment #5 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-03-18 10:42:05 EDT ---
(In reply to comment #4)
> (In reply to comment #3)
> > Also, as you are a new packager you should make a habit of running rpmlint on
> > all your packages and paste the output in the Review Request every time you put
> > in a new release (up to the package being accepted, that is).  
> 
> I'll do that. The only reason I didn't do it is because
> https://fedoraproject.org/wiki/Package_Review_Process didn't mention it.
> However, for my package rpmlint (0.85) doesn't print any errors/warnings:

Yeah, but it's nicer for the reviewer that way :)

- You should increment the release number every time you make a new release,
and add a short comment about the changes you've done to the changelog. This
applies also during the review process.

- Installation does not preserve time stamps. Change
 make install DESTDIR=$RPM_BUILD_ROOT
to:
 make install INSTALL="install -p" DESTDIR=$RPM_BUILD_ROOT

- AUTHORS and ChangeLog are missing from documentation.

After these changes the package is good to go.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.