[Bug 476398] Review Request: eclib - A Library for Doing Computations on Elliptic Curves

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476398





--- Comment #22 from Conrad Meyer <konrad at tylerc.org>  2009-03-19 16:26:45 EDT ---
(In reply to comment #21)
> Created an attachment (id=335928)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=335928) [details]
> spec patch for check section
> 
> Great, one of the tests fails even. :)  If upstream cannot reproduce it by
> running "spkg-check" manually, it would be Fedora-specific.

Probably why I didn't include them initially.

> That's splitting-hairs. You could apply your weird theory to every package and
> move even applications into -devel packages. *This* package builds shared
> libraries, which are used at run-time. A -devel package, on the contrary, is
> fully optional. A run-time package must not depend on a -devel package.

It's not some weird theory I personally have to go out of my way to harm
Fedora, I just assume the writers of the guidelines were more knowledgeable
about shared libraries and sonames than I am.

> > That's a comma. It's there to separate two ideas.
> 
> Doesn't matter, you moved the shared libs actually. That breaks the package
> badly already. It's a blocker during review. Shared libs in wrong path, no
> ldconfig scriptlets either.

I also added sonames, which is what "fixing the soname mess" was referring to.
They don't have versions, though. Look at the patch in the last SRPM.

> > They can be moved back if you like.
> 
> It will be required for this package to pass review.

Done.


You know, you can offer constructive criticism without being rude or attacking.
I don't mean you or Fedora any harm.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.