[Bug 480279] Review Request: gnome-globalmenu - centralized menu bar

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480279





--- Comment #19 from Christoph Wickert <fedora at christoph-wickert.de>  2009-03-19 16:37:57 EDT ---
Include the correct license. Ether cat GPLv2 > COPYING during %prep or simply
install the GPLv2 file as is.

(In reply to comment #18)

> It is a GPLv2. The GPLv3 file is not used for licensing. The COPYING file
> contains wrong content. 

> What about adding links to the real ChangeLog and NEWS on the web in these
> empty files?

Ok for me, but in a long term proper documentation inside the package would be
better. BTW: README contains a wrong URL:
http:///gnome2-globalmenu.googlecode.com (note the tripple slashes)

> Only on Fedora.
> the xfce4-panel plugin can't build on RHEL5, because the dependency are not
> satisfied.

If it cant be built on RHEL5 I guess it wont build in RHEL4 ether, right? 

> There are post installation configuration steps. You have to export
> GTK_MODULES=globalmenu-gnome. Where should this be mentioned?  

Ether in the description of xfce4-globalmenu-plugin or in a README.Xfce. I
suggest to add a hint to the description that points to README.xfce:

  %description -n xfce4-globalmenu-plugin
  The XFCE panel applet of Global Menu is a representation of Global Menu 
  with GTK widgets. The applet can be inserted to the default top panel 
  to provide access to the Global Menu of the applications. 

(BTW: There no longer is default top panel in Xfce 4.6, just a single panel at
the bottom)

  To enable the xfce4-globalmenu-plugin you need to follow the instructions
  outlined in %{_docdir}/%{name}-%{version}/README.xfce.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.