[Bug 226146] Merge Review: mkinitrd

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226146


Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jussi.lehtola at iki.fi




--- Comment #1 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-03-20 16:40:48 EDT ---
The package needs some amount of love:

grubby.x86_64: E: executable-marked-as-config-file /sbin/installkernel
grubby.x86_64: E: tag-not-utf8 %changelog
grubby.x86_64: W: invalid-url git://git.fedoraproject.org/git/hosted/mkinitrd
grubby.x86_64: W: non-etc-or-var-file-marked-as-conffile /sbin/installkernel
grubby.x86_64: W: conffile-without-noreplace-flag /sbin/installkernel
libbdevid-python.x86_64: W: no-documentation
libbdevid-python.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.5/site-packages/bdevid.so 0775
libbdevid-python.x86_64: E: explicit-lib-dependency device-mapper-libs
libbdevid-python.x86_64: E: explicit-lib-dependency libselinux
libbdevid-python.x86_64: E: explicit-lib-dependency libsepol
libbdevid-python.x86_64: E: tag-not-utf8 %changelog
libbdevid-python.x86_64: W: invalid-url
git://git.fedoraproject.org/git/hosted/mkinitrd
mkinitrd.src: E: non-utf8-spec-file
/tmp/mkinitrd-6.0.81-1.fc10.src.rpm.30578/mkinitrd.spec
mkinitrd.src:1614: W: macro-in-%changelog config
mkinitrd.src: W: summary-ended-with-dot Creates an initial ramdisk image for
preloading modules.
mkinitrd.src: E: tag-not-utf8 %changelog
mkinitrd.src: W: invalid-url git://git.fedoraproject.org/git/hosted/mkinitrd
mkinitrd.x86_64: E: explicit-lib-dependency libselinux
mkinitrd.x86_64: E: explicit-lib-dependency libsepol
mkinitrd.x86_64: W: summary-ended-with-dot Creates an initial ramdisk image for
preloading modules.
mkinitrd.x86_64: E: tag-not-utf8 %changelog
mkinitrd.x86_64: W: invalid-url git://git.fedoraproject.org/git/hosted/mkinitrd
mkinitrd.x86_64: E: no-binary
mkinitrd-debuginfo.x86_64: E: tag-not-utf8 %changelog
mkinitrd-debuginfo.x86_64: W: invalid-url
git://git.fedoraproject.org/git/hosted/mkinitrd
mkinitrd-devel.x86_64: W: no-documentation
mkinitrd-devel.x86_64: W: no-version-dependency-on
mkinitrd/mkinitrd-libs/libmkinitrd 6.0.81
mkinitrd-devel.x86_64: W: summary-ended-with-dot C header files and library for
functionality exported by libnash.
mkinitrd-devel.x86_64: E: tag-not-utf8 %changelog
mkinitrd-devel.x86_64: W: invalid-url
git://git.fedoraproject.org/git/hosted/mkinitrd
nash.x86_64: E: non-standard-executable-perm /lib64/bdevid/usb.so 0775
nash.x86_64: E: library-without-ldconfig-postin /usr/lib64/libbdevid.so.6.0.81
nash.x86_64: E: library-without-ldconfig-postun /usr/lib64/libbdevid.so.6.0.81
nash.x86_64: E: non-standard-executable-perm /lib64/bdevid/scsi.so 0775
nash.x86_64: E: non-standard-executable-perm /lib64/bdevid/ata.so 0775
nash.x86_64: E: library-without-ldconfig-postin /usr/lib64/libnash.so.6.0.81
nash.x86_64: E: library-without-ldconfig-postun /usr/lib64/libnash.so.6.0.81
nash.x86_64: E: explicit-lib-dependency device-mapper-libs
nash.x86_64: E: explicit-lib-dependency e2fsprogs-libs
nash.x86_64: E: explicit-lib-dependency libselinux
nash.x86_64: E: explicit-lib-dependency libsepol
nash.x86_64: E: explicit-lib-dependency zlib
nash.x86_64: W: summary-not-capitalized nash
nash.x86_64: E: tag-not-utf8 %changelog
nash.x86_64: W: invalid-url git://git.fedoraproject.org/git/hosted/mkinitrd
7 packages and 0 specfiles checked; 28 errors, 17 warnings.

In addition:
- Requires and BuildRequires are a mess. Please: alphabetize and break
requirements one per line. At least fix mixed use of spaces and commas.

- Drop ExclusiveOs

- BuildRoot should be
%(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)

- Description of nash should be extended.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.