[Bug 490317] Review Request: rumor - Really Unintelligent Music transcriptOR

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490317





--- Comment #1 from Christian Krause <chkr at plauener.de>  2009-03-20 19:03:58 EDT ---
Hi Orcan,

here is my official review, there are only 2 very minor issues:

* rpmlint: TODO
rpmlint SPECS/rumor.spec RPMS/i386/rumor-* SRPMS/rumor-1.0.3b-1.fc10.src.rpm
SPECS/rumor.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 12, tab: line
1)
rumor.src: W: mixed-use-of-spaces-and-tabs (spaces: line 12, tab: line 1)
3 packages and 1 specfiles checked; 0 errors, 2 warnings.
- just a very minor mixture of spaces and tabs

* spec file name: OK

* Source0: OK
- spectool -g works
- URL ok
- sources matches upstream: md5sum
c95917356659b77bb83505cb2512ad1b  rumor-1.0.3b.tar.bz2

* package name: OK, matches upstream

* license: OK
- GPLv2 is acceptable
- rumor.cc explicitely states that "version 2 as published by the Free Software
Foundation" should be used
- license field matches actual license
- COPYING packaged

* spec file legible and in American English: OK

* package compiles: OK
- mock
- koji in F9, F10 and F11:
https://koji.fedoraproject.org/koji/taskinfo?taskID=1251851
https://koji.fedoraproject.org/koji/taskinfo?taskID=1251856
https://koji.fedoraproject.org/koji/taskinfo?taskID=1251861

* BuildRequires: OK

* locale handling: OK (no locale available)

* shared libs handling: OK (no shared libs)

* directory ownership: OK
- no directories created

* debuginfo: OK
- seems to be complete, debuginfo available in gdb for rumor

* files not listed twice: OK

* optflags: TODO
- I would delete the -O0 in the configure file completely and not substitute it
with -O2. If Fedora changes the rpmoptflags, there will be two different -Ox
options (the one from rpmoptflags and the one from the configure) (e.g. "sed -i
's|-O0||' configure" could be used)
- the only uncommon gcc option is "-ggdb3", but that's no problem, it will only
add some more info to the debug infos (e.g. macros) - gdb works still fine with
rumor's debuginfo

* %clean and rm -rf in %install: OK

* file perms: OK

* %defattr used: OK

* macro usage: OK

* code vs. content: OK
- only code

* large docu in sub-package: OK (n/a)

* *.la files, header, static/dynamic libs, pkgconfig: OK (n/a)

* GUI application needs desktop file: OK (not a GUI app)

* file names UTF8: OK

* basic features: OK
- I've used rumor together with frescobaldi to record some notes from a
keyboard attached via MIDI. It worked without any problems.

* scriptlets: OK
- texinfo: Requires ok
- scriptlets for texinfo files correct
- /usr/share/info/dir not part of the package

Best regards,
Christian

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.