[Bug 489564] Review Request: Blueman - Bluetooth Manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=489564





--- Comment #23 from Christian Krause <chkr at plauener.de>  2009-03-20 19:34:56 EDT ---
Hello,

(In reply to comment #18)
> I tried compiling using Koji, but got "Policy Violation" errors. Maybe I'm
> doing something wrong?
> http://koji.fedoraproject.org/koji/taskinfo?taskID=1242686
> I also noticed that dist-f9 and dist-f10 appear to be "locked"... I wonder what
> that's about?

It looks like that you've tried to do an "official" build for these packages,
but right now you can do only scratch builds. Please try: "koji build --scratch
dist-f9 path/to/my.src.rpm"

> Spec URL:
> http://proyectofedora.org/mexico/wp-content/uploads/2009/03/blueman.spec

I've roughly scanned over your new spec file, there are still some minor
issues:

* when using %{_datadir}/%{name}/* , only the entries of the directory
%{_datadir}/%{name} will be owned by the package, but not the directory itself.
Please use %{_datadir}/%{name}/

* desktop-file: TODO
- update-desktop-database not needed since the destkop file doesn't include a
mimetype:
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database

* if you like, you can also try to use the suggestion from Rajeesh to use
--disable-static to avoid the build of the *.la and *.a files completely (and
so to avoid to remove them explicitely)

* Since this package may interfere with the existing bluez-* and
gnome-bluetooth packages, it is necessary to test it. Please have a look at my
comments regarding the "functional check" and address them. Thanks!

Best regards,
Christian

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.