[Bug 476398] Review Request: eclib - A Library for Doing Computations on Elliptic Curves

bugzilla at redhat.com bugzilla at redhat.com
Sun Mar 22 13:47:08 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476398





--- Comment #35 from Michael Schwendt <bugs.michael at gmx.net>  2009-03-22 09:46:53 EDT ---
Created an attachment (id=336199)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=336199)
eclib-20080310.p7-build.patch

I've found the problem after a close look. It's a packaging mistake.

Parts of the code are miscompiled because the OPTFLAG environment variable is
redefined and alters the source tarball's build flags. The NEW_OP_ORDER
definition is lost. That miscompiles some source files.

The cleaner way would be to patch the src/Makefile and make it accept our
$RPM_OPT_FLAGS from the outside. It already accepts $PICFLAG for "-fPIC". With
this change it is not necessary to move fundamental build flags into the spec
file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list