[Bug 486757] Review Request: divine-mc - Multi-core model checking system for proving specifications

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486757





--- Comment #14 from David A. Wheeler <dwheeler at dwheeler.com>  2009-03-22 10:44:50 EDT ---
Okay, I've tried to respond to all changes from Comment #13 ; the sole
exception is that I didn't version Java (it makes Fedora 10 builds fail, and
doesn't seem necessary).  Comments?  First, a discussion of how I handled each
comment...

First, thanks for coordinating with upstream!!  I appreciate that.

I've installed all the binaries as you suggested.  I had earlier figured that
if they weren't getting installed, they were less mature, but I agree that
letting users make the decision of what to run is reasonable.

I'll go package Promela next, so that it can be removed from divine-mc 2.0. 
But I don't think Java needs to be versioned; can you help me understand why it
must be, before I do that? (I'll use this package as a starting point.)

Regarding: "please fix the cmake install target, make sure that the Perl
dependencies are ok then, see:
https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides " I
don't see anything that needs doing.  It doesn't use much of perl, and it's not
a perl module.

I switched to the upstreams tarball URL, and added the link to trac ticket on
why it's not currently packaged separately.

You said: "regarding Java, the BR and R should be versioned, hence please use:
BuildRequires:  java-devel >= 1:1.6.0 ... 
Requires:       java >= 1:1.6.0"  Versioning Java makes the Fedora 10 build
fail, and doesn't seem necessary; 1.5 seems to work just fine.

I surrounded the "take too long" test as suggested.  Very nice!

"I would appreciate if you would submit the review request for Promela before
approving this package (the package and review shouldn't be problematic
AFAIK)."  I understand.   But can you explain why you think java and java-devel
need to be versioned?

I did rpmlint on the .src.rpm, .spec, and a binary RPM.  The only message is:
"divine-mc.src:134: W: configure-without-libdir-spec"
and as discussed earlier, this is a bogus warning.

I built this with koji on dist-f10 and dist-f11, builds on all architectures:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1252929
  0 free  0 open  5 done  0 failed
http://koji.fedoraproject.org/koji/taskinfo?taskID=1252947
  0 free  0 open  5 done  0 failed

Here's the latest SRPM:
 http://www.dwheeler.com/divine-mc-1.3-7.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.