[Bug 491550] Review Request: libass - Portable library for SSA/ASS subtitles rendering
bugzilla at redhat.com
bugzilla at redhat.com
Mon Mar 23 00:07:10 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491550
Dominik 'Rathann' Mierzejewski <rpm at greysector.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #2 from Dominik 'Rathann' Mierzejewski <rpm at greysector.net> 2009-03-22 20:06:55 EDT ---
Full review:
rpmlint clean:
$ rpmlint /var/lib/mock//fedora-rawhide-x86_64/result
libass-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 1 warnings.
source matches upstream:
$ md5sum libass-0.9.6.tar.bz2 libass-0.9.6.tar.bz2.orig
58d9fa08eedc27edae05b53288025370 libass-0.9.6.tar.bz2
58d9fa08eedc27edae05b53288025370 libass-0.9.6.tar.bz2.orig
Builds fine in mock(devel/x86_64).
Just one small issue:
Redundant BuildRequires:
glibc-devel (required by gcc, which is in exceptions)
freetype-devel (required by fontconfig-devel)
Other than that it's fine.
This package is APPROVED.
(But please fix the redundant BRs upon import.)
I also encourage you to work with avidemux maintainer (in RPM Fusion) to
unbundle its internal copy of libass.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list