[Bug 225945] Merge Review: jfsutils

bugzilla at redhat.com bugzilla at redhat.com
Mon Mar 23 14:26:45 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225945





--- Comment #12 from Josh Boyer <jwboyer at gmail.com>  2009-03-23 10:26:27 EDT ---
(In reply to comment #11)
> (In reply to comment #10)
> > (In reply to comment #9)
> > > .. Not so fast! I didn't do the review yet, or approve the package!
> > > 
> > > - Please use %configure instead of ./configure. If you
> > > %global _sbindir /sbin
> > 
> > Why is that needed?  It should be done in the buildsys already...  
> 
> Because by default _sbindir is /usr/sbin. This redefinition makes the spec file
> cleaner, and is used in other system tool specs too.  

Yeah, noticed that.  I'm not thrilled with overriding the macro though, so I'll
just specify /sbin.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.




More information about the Fedora-package-review mailing list