[Bug 491694] Review Request: Anyterm - Web based terminal emulator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=491694


Itamar Reis Peixoto <itamar at ispbrasil.com.br> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |itamar at ispbrasil.com.br




--- Comment #1 from Itamar Reis Peixoto <itamar at ispbrasil.com.br>  2009-03-23 12:57:35 EDT ---
1 - replace 

test "x$RPM_BUILD_ROOT" != "x" && rm -rf $RPM_BUILD_ROOT
mkdir %{buildroot}

with

rm -rf $RPM_BUILD_ROOT


2 - look about source0 

https://fedoraproject.org/wiki/Packaging/SourceURL

3 - missing dist-tag

Release:        1%{?dist}

4 - you can make install section smaller, merging commands, there are no need
of install -d if install -Dp create directory's

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.