[Bug 225945] Merge Review: jfsutils
bugzilla at redhat.com
bugzilla at redhat.com
Mon Mar 23 19:23:07 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225945
--- Comment #15 from Jussi Lehtola <jussi.lehtola at iki.fi> 2009-03-23 15:22:48 EDT ---
(In reply to comment #14)
> Changes are in cvs now (except the INSTALL/README thing because I forgot it and
> it's not really that important).
>
> I'll wait before doing another build until I get the magic approval
Drop the unnecessary stuff from the configure phase, it should read just
%configure --sbindir=/sbin
since all of the other stuff is already in the %configure script.
Or, if you redefine sbindir as I mentioned before the configure phase is just
%configure
as the redefined sbindir is automatically expanded.
IMHO it's nicer to just redefine sbindir and use %{_sbindir} everywhere instead
of /sbin.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
More information about the Fedora-package-review
mailing list