[Bug 491519] Review Request: openttd-opengfx - OpenGFX replacement graphics for OpenTTD

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=491519





--- Comment #6 from Alexey Torkhov <atorkhov at gmail.com>  2009-03-24 04:59:10 EDT ---
(In reply to comment #5)
> Requires: openttd
> seems wrong (because openttd requires this for graphics). I think maybe a
> solution is for this to go in %{_datadir}/%{name}/ and when openttd is
> installed and requires this, it can symlink %{_datadir}/openttd/data to this
> package (if it's too hard to change where openttd looks).

This Requires is needed for game data uninstalled simultaneously with the game
itself. It is pretty standard among game data packages.

> This is one argument for including opengfx in openttd (opengfx can be
> installed into the correct place without a hack, and the two-way requires
> can be avoided).

Separating game from game data allows to decrease size of updates as there is
no need to update data when binary updated and vice versa.
And, after all, bundling multiple projects in not recommended by guidelines.

> The use of __<command> macros is unnecessary (%{__rm}, %{__mv}, etc). Fedora
> is not Mandriva.

Agree with this. It makes macros usage non-consistent. Please fix it.

> This bit concerns me (slightly):
> # These are already in %doc
> %{__rm} $RPM_BUILD_ROOT%{_datadir}/openttd/data/COPYING
> %{__rm} $RPM_BUILD_ROOT%{_datadir}/openttd/data/readme.txt
> Are these really never used by OpenTTD? If so it's fine. 

OpenTTD uses metadata from *.obg. Those files are only docs.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.