[Bug 492398] Review Request: slv2 - LV2 host library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492398





--- Comment #3 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com>  2009-03-28 15:20:30 EDT ---
Thank you for the review!

(In reply to comment #2)
> > $ pkg-config --libs slv2
> > -lrdf -lrasqal -lraptor -lslv2  
> 
> > $ pkg-config --libs redland
> > -lrdf -lrasqal -lraptor
> 
> The slv2.pc file is optimised for static linking in that it adds the
> @REDLAND_LIBS@ libs which the shared libslv2 is linked with already. Can be
> fixed in both packages.
> 

I removed @REDLAND_*@ from the .pc file

> 
> > export CFLAGS="%{optflags}"
> > export CPPFLAGS="%{optflags}"
> 
> CPPFLAGS duplicates the CFLAGS during compilation. You want to define CXXFLAGS
> instead, although this project is in plain C.
> 
> 

Sorry, I missed this. Fixed.

> > slv2_plugininstance.h_r1948.diff
> 
> Does any slv2 header actually require definitions found within <stdlib.h>? Or
> is it just the plugins that ought to include stdlib.h instead? The comment in
> the spec doesn't explain this.
> 
> 

It was me who reported this upstream. The file plugininstance.h refers to
"NULL" which is undefined unless stdlib.h is included.

Ref: http://dev.drobilla.net/ticket/341

> 
> * Main slv2 package contains API html documentation, which belongs into the
> -devel package. EasyFix.
> 
> 

Done.

> * Do we have any dependencies for SLV2 already to test with? [Audacity has
> dropped SLV2/Redland usage prior to releasing 1.3.7-beta]  

You can re-compile ardour with SLV2 support. We will do this after this package
hits to repos. Also there is traverso in rpmfusion that you can try out:
https://bugzilla.rpmfusion.org/show_bug.cgi?id=traverso


Spec URL: http://oget.fedorapeople.org/review/slv2.spec
SRPM URL: http://oget.fedorapeople.org/review/slv2-0.6.2-2.fc10.src.rpm

Changelog: 0.6.2-2
- Remove redland flags from the .pc file
- Change CPPFLAGS to CXXFLAGS
- Move API documentation to the -devel package

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.