[Bug 497640] Review Request: rubygem-RedCloth - Textile parser for Ruby.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497640


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




--- Comment #8 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-05-01 00:06:43 EDT ---
Some notes:

* About shebang or so related rpmlint warning
------------------------------------------------------------
find %{buildroot}%{geminstdir} -name "*.rb" | xargs chmod a+x

for script in \
    /lib/case_sensitive_require/RedCloth.rb \
....
....
    /extras/ragel_profiler.rb;
do
    chmod +x %{installroot}/$script
    sed -i -e '1i #!/usr/bin/ruby' %{installroot}/$script
done
------------------------------------------------------------
  - No, this is not right. If these ruby scripts are not
    meant to be executed directly from user, these script
    should not have shebang and should have 0644 permission.
    Rather the following is correct:
------------------------------------------------------------
find %{buildroot}%{geminstdir}/test -type f -name \*.rb | \
 xargs grep -l "^#!%{_bindir}/env" | xargs chmod 0755
------------------------------------------------------------

* About copying files into ruby_sitelib
------------------------------------------------------------
cp %{installroot}/lib/redcloth.rb %{buildroot}%{ruby_sitelib}/redcloth.rb
------------------------------------------------------------
  - What is this line for?

* Documents
  - IMO the following files/directories should be marked as
    %doc:
------------------------------------------------------------
%{geminstdir}/[A-Z]*
%{geminstdir}/test/
------------------------------------------------------------


* About missing files for debuginfo rpm:
  - I wrote a comment for this on fedora-packaging list.
    This is not rubygem specific issue.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.