[Bug 481701] Review Request: python-TraitsGUI - Traits-capable windowing framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481701





--- Comment #4 from Rakesh Pandit <rpandit at redhat.com>  2009-05-02 05:43:41 EDT ---
> * Please update to the latest version (3.0.4)

         It is too new to take up and not much changes ... as this package is
dependency for whole Mayavi stack which is very big... I would only take it ..
after it goes some thorough testing. The one I am using is tested with other
packages.

> * %{version} should be dropped from URL.

Done

> * Please make the description span 80 columns.

It was already under 80 columns. Still I have adjusted a bit.

>* For macro consistency you should either convert X to %{__X}, where
>X=(sed,mv,rm), or convert %{__python} to python


Done.

> * Please preserve the timestamps of the .txt files.  

https://fedoraproject.org/wiki/Common_Rpmlint_issues#file-not-utf8

to convert files not in utf8 to utf8 .. I am using above method. Due you have a
better way to save timestamp here? I don't know .. whether it is worth for
these files.


Updated:
http://rakesh.fedorapeople.org/srpm/python-TraitsGUI-3.0.3-3.fc10.src.rpm
http://rakesh.fedorapeople.org/spec/python-TraitsGUI.spec


Thanks,

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.