[Bug 495902] Review Request: olpc-kbdshim - grab key and better rotation support for the XO laptop

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=495902





--- Comment #3 from Christoph Wickert <fedora at christoph-wickert.de>  2009-05-02 20:49:43 EDT ---
(In reply to comment #2)
> 
> okay.  i can't find a reference for %{dist}.  when is it set?

in rpmmmacros, see http://fedoraproject.org/wiki/Packaging:DistTag


> there won't normally be an upstream tarball location.  the srpm comes from the
> same place the tarball would -- i.e., git.  so i commented Source0 as in:
>     https://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control
> is that okay?

Yes, but add a comment how the tarball was generated.
> 
> > - Please replace 'BuildArch' with 'ExcludeArch'
> >   https://fedoraproject.org/wiki/Architectures#ExcludeArch_.26_ExclusiveArch
> 
> i suppose.  but this package really is intended just for the XO laptop -- it
> specifically supports the "Grab" keys on the XO keyboard, and handles rotation
> of the touchpad and local bezel-mounted arrow pad when the XO "rotate" button
> is used.  i didn't see a point in building for non-i386 platforms.  should i
> simply remove the BuildArch line?  i confess i won't be much interested in
> fixing build problems for architectures on which this will never run.


> what's the next step?  after fixing, do i build new rpms for you (or someone
> else) to look at?  or would just a spec file be enough?

We are reviewing rpms, not specs, so please build a new package for me to
review. I can also take over sponsorship. And of course I have to test this on
my XO first.

URL does not work. 

And worst of all this patching thing wont work. How is one supposed to
uninstall it? You need at least make a backup of the file that is restored when
the package is uninstalled. Even this is *very* dirty, i never want to see
anything like that in Fedora, but maybe we can make an exception for OLPC.
Alternatives would be much better.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.