[Bug 498736] Review Request: ucommon - Portable C++ runtime for threads and sockets
bugzilla at redhat.com
bugzilla at redhat.com
Sun May 3 06:56:48 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=498736
Jussi Lehtola <jussi.lehtola at iki.fi> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jussi.lehtola at iki.fi
--- Comment #8 from Jussi Lehtola <jussi.lehtola at iki.fi> 2009-05-03 02:56:47 EDT ---
- Don't ship static libraries. Try adding --disable-static to %configure. If
you can't get static libraries not to build, your development package needs to
Provides: %{name}-static = %{version}-%{release}.
- The dependency of the devel package on the main package must be fully
versioned: Requires: %{name} = %{version}-%{release}
- Instead of having
%dir %{_includedir}/ucommon
%{_includedir}/ucommon/*.h
in the devel file section just put simply
%{_includedir}/ucommon/
as this will include the directory and all the files in it. You can also leave
out the trailing slash but having it makes the statement a bit clearer.
- Do you really need to set
%attr(0755,root,root) %{_bindir}/ucommon-config
won't a simple
%{_bindir}/ucommon-config
do?
- You have the Group attribute set twice on the main package.
- %configure automatically sets CXXFLAGS="$RPM_OPT_FLAGS", you don't need that.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list