[Bug 497800] Review Request: perl-Acme-PlayCode - Perl module for enhancement of code

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497800





--- Comment #4 from Chris Weyl <cweyl at alumni.drew.edu>  2009-05-03 13:43:05 EDT ---
Generally speaking, dos2unix (or the ever popular "sed -e 's/\r//'") doesn't
strictly belong in %prep, but it fits far better in there than it does in
%build.  Stripping dos-like EOL characters from source is as much preparing it
as is patching it, or removing errant execute bits, etc.  Absent a very
compelling reason, we wouldn't include a %patch in %build, would we?

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1334190

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
0034e6c7961d2f9ed8b5e6ad60ac7333941d73d9 Acme-PlayCode-0.11.tar.gz
0034e6c7961d2f9ed8b5e6ad60ac7333941d73d9 Acme-PlayCode-0.11.tar.gz.srpm

Final provides / requires are sane:

0 packages and 1 specfiles checked; 0 errors, 0 warnings.
=====> perl-Acme-PlayCode-0.11-2.fc12.noarch.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-Acme-PlayCode-0.11-2.fc12.noarch.rpm
perl(Acme::PlayCode) = 0.11
perl-Acme-PlayCode = 0.11-2.fc12
perl(Acme::PlayCode::Plugin::Averything) = 0.10
perl(Acme::PlayCode::Plugin::DoubleToSingle) = 0.10
perl(Acme::PlayCode::Plugin::ExchangeCondition) = 0.10
perl(Acme::PlayCode::Plugin::NumberPlus) = 0.11
perl(Acme::PlayCode::Plugin::PrintComma) = 0.10
====> requires for perl-Acme-PlayCode-0.11-2.fc12.noarch.rpm
perl(Data::Dumper)  
perl(List::MoreUtils)  
perl(:MODULE_COMPAT_5.10.0)  
perl(Moose)  
perl(Moose::Role)  
perl(Path::Class)  
perl(PPI)  
perl(PPI::Token::Comment)  
perl(vars)  

=====> perl-Acme-PlayCode-0.11-2.fc12.src.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-Acme-PlayCode-0.11-2.fc12.src.rpm
====> requires for perl-Acme-PlayCode-0.11-2.fc12.src.rpm
dos2unix  
perl(List::MoreUtils)  
perl(Module::Build)  
perl(Moose) >= 0.57
perl(MooseX::Object::Pluggable) >= 0.0008
perl(Path::Class) >= 0.16
perl(PPI) >= 1.201
perl(Test::More)  
perl(Test::Pod)  

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.