[Bug 492397] Review Request: websvn - Online subversion repository browser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492397





--- Comment #5 from Xavier Bachelot <xavier at bachelot.org>  2009-05-03 19:03:45 EDT ---
(In reply to comment #3)
> 1] rpmlint is not silent on actual package

websvn.noarch: W: non-standard-uid /var/cache/websvn apache
websvn needs this to be able to temporarily cache some generated files. The
owner is indeed apache.

websvn.noarch: W: dangling-relative-symlink /usr/share/websvn/temp
../../../var/tmp
I believe this warning is bogus. /var/tmp exists on the file system. I've tried
to fix this, but failed. I'd love to see it fixed though and I welcome any
suggestion. 

> 2] do you really need patch for replacing 3 lines? sed with comment in %prep
> will be imho better readable.

Well, the patch is perfectly legible imo. And also, I'd rather not use sed for
this kind of thing, it would be too easy to break things w/o noticing. I'd
rather keep a patch and possibly rebase it if the underlying code changes,
rather than silently breaking it with sed.

> 3] I think that it would be good to add webserver into requires. Because websnv
> wouldn't work without webserver.
Right, and also the package wouldn't even install because the apache user
wouldn't exist. I'll add :
Requires(pre): httpd

(In reply to comment #4)
> If the provided config files works with httpd I think it's better to require it
> rather than a generic web server. On the other hand, those _not_ wanting to use
> httpd as web server will be disappointed...
> 
> A possible solution to this (used in the mantis package) is to split the config
> file in a subpackage and let that require httpd.  

It looks a bit too much to me to have a subpackage just for the apache conf and
I'm not sure this would be enough anyway, because some files are owned by the
apache user. Actually, I've never used any other webserver, and I'm not sure
how, say lighttpd, works (user, conf file, etc...). I'll dig the guidelines for
advices. Any pointers welcome.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.