[Bug 497661] Review Request: perl-MIME-EncWords - Deal with RFC 2047 encoded words

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497661


Bug 497661 depends on bug 497660, which changed state.

Bug 497660 Summary: Review Request: perl-MIME-Charset - Charset Informations for MIME
https://bugzilla.redhat.com/show_bug.cgi?id=497660

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE



--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-05-04 00:58:43 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1334537
+ rpmlint output for SRPM and for RPM.
perl-MIME-EncWords.noarch: E: useless-provides perl(MIME::EncWords)
=> This package provides 2 times the same capacity. It should only provide it

+ source files match upstream url
2009449d0af39275d45e45a4afcaf58f  MIME-EncWords-1.010.101.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=2, Tests=74,  0 wallclock secs ( 0.04 usr  0.00 sys +  0.14 cusr  0.02
csys =  0.20 CPU)
+ Package perl-MIME-EncWords-1.010.101-1.fc12.noarch =>
Provides: perl(MIME::EncWords) perl(MIME::EncWords) = 1.010.101
Requires: perl >= 0:5.005 perl(Exporter) perl(strict) perl(vars)
+ Not a GUI application

suggestions:
1) make sure to remove unnecessary provides perl(MIME::EncWords)
2) you don't need 
Requires:       perl(MIME::Charset) >= 1.006.2


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.