[Bug 499087] Review Request: perl-Locale-PO - Perl module for manipulating .po entries from GNU gettext
bugzilla at redhat.com
bugzilla at redhat.com
Tue May 5 08:24:06 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499087
Parag AN(पराग) <panemade at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2009-05-05 04:24:03 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1336384
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
2cb9a5f472e944685c43588e18f24fcb6101de47 Locale-PO-0.21.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=3, Tests=30, 0 wallclock secs ( 0.01 usr 0.00 sys + 0.15 cusr 0.03
csys = 0.19 CPU)
+ Package perl-Locale-PO-0.21-1.fc12.noarch =>
Provides: perl(Locale::PO) = 0.21
Requires: perl(Carp) perl(strict) perl(warnings)
+ Not a GUI application
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list