[Bug 489686] Review Request: Armadillo - fast C++ matrix library with interfaces to LAPACK and ATLAS

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=489686





--- Comment #10 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-05-07 08:19:28 EDT ---
A few notes:

- gcc-c++, libstdc++-devel are not needed. First, BR libstdc++-devel is
redundant since it's required by gcc-c++, second gcc-c++ is already in the
standard kit installed in the buildroot:
http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

- Also blas-devel is unnecessary since it's pulled in by lapack-devel.

- The section
 mkdir -p $RPM_BUILD_ROOT/%{_docdir}/%{name}-%{version}
 cp -r -p README.txt LICENSE.txt index.html examples docs_user docs_tech
licenses $RPM_BUILD_ROOT/%{_docdir}/%{name}-%{version}
is unnecessary. Just insert
 %doc README.txt LICENSE.txt index.html examples docs_user docs_tech licenses
in the %files section of the main package. Also, note that if the documentation
is large, it should be branched in its own package, which may be the case here.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.