[Bug 499319] Review Request: tcl-snmptools - TCL extension for SNMP support

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=499319





--- Comment #3 from Bryson Lee <bamablee at gmail.com>  2009-05-07 20:33:26 EDT ---
Hi Guido, thanks for the review!

Spec URL: http://www.slac.stanford.edu/~blee/tcl-snmptools.spec
SRPM URL: http://www.slac.stanford.edu/~blee/tcl-snmptools-1.0-3.fc10.src.rpm

> - use %global instead of %define

Corrected.

> - include the file license.terms in %doc

Corrected.

> - some files are under CMU license (BSD like), fix the License tag

Corrected to "CMU and GPLv3+".


> NEEDSWORK - Every binary RPM package which stores shared library files must
> call ldconfig in %post and %postun
> - add ldconfig calls

Although the guidelines don't say so explicitly, I don't think it makes sense
to apply this requirement to shareables that are extension modules for
interpreted languages like TCL, since the code isn't activated by ld itself,
but rather by the interpreter (e.g. /usr/bin/tclsh) with calls to dlopen(). 
This specfile was based on an existing Fedora 10 specfile for the tcl-zlib
extension, which does not perform ldconfig calls, either.

Best regards,

Bryson

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.