[Bug 489686] Review Request: armadillo - fast C++ matrix library with interfaces to LAPACK and ATLAS

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=489686





--- Comment #15 from Conrad Sanderson <conradsand at ieee.org>  2009-05-07 22:10:07 EDT ---
(In reply to comment #10)
> A few notes:
> 
> - gcc-c++, libstdc++-devel are not needed.

Thanks -- I've removed the explicit build dependencies.

> http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

Based on rpm -qR, boost-devel doesn't pull in libstdc++-devel.  Armadillo
header files certainly need the header files provided by libstdc++-devel, and
I'd assume boost-devel would also.

As such, should there be a dependency on libstdc++-devel in the -devel package?

The packaging guidelines only state that gcc-c++ (and hence libstdc++-devel)
can be assumed to exist for "BuildRequires". Is this also the case for the
"Requires" section ?


> Just insert
> %doc README.txt LICENSE.txt ... in the %files section of the main package. 

I've adapted this as follows:

%files
...
%doc LICENSE.txt licenses

%files devel
...
%doc README.txt index.html examples docs_user docs_tech

The reasoning is that the licensing applies whether or not the header files are
present.  "README.txt" and "index.html" refer to files which are only present
when both the base and -devel package are installed (due to the layout in the
original .tar.gz archive).

> Also, note that if the documentation is large, it should be 
> branched in its own package, which may be the case here.  

I'd prefer to keep it in the -devel package to keep thing simpler, and hence
less error prone. (I'd also prefer not to go overboard in splitting packages
like Debian does).  The documentation goes hand in hand when one does
development using this library, so I'm not sure if the added complexity and
effort of an extra doc package is worth it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.