[Bug 500074] Review Request: libplist - Library for manipulating Apple Binary and XML Property Lists

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=500074





--- Comment #5 from Peter Robinson <pbrobinson at gmail.com>  2009-05-11 12:49:31 EDT ---

> I guess the "no-documentation" ones can be ignored.
> You should also use the python_sitelib macro, as the module should live in
> /usr/lib64/python2.5/...

Plan on doing that but it somewhere slightly non default (looking at my system
its not the only one that does it) but I have reported it upstream and will
correct.

> For the sub-packages, I'd rather have:
> Development files for %{name}, <insert short description>.
> 
> Similar for the python sub-package.

No problems. Fixed.

> I think the -python sub-package is missing a python requires. Rest looks good.  

I thought that python was automatically done. It appears not. Fixed.

SPEC is same spot as before.
SRPM: http://pbrobinson.fedorapeople.org/libplist-0.12-2.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.