[Bug 458090] Review Request: LuxRender - Lux Renderer, an unbiased rendering system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458090





--- Comment #24 from Nicolas Chauvet (kwizart) <kwizart at gmail.com>  2009-05-13 11:56:19 EDT ---
(In reply to comment #22)
...
> TODO
> - Please set blender requirement to bleder >= 2.48a-21 to
>   make sure, that the script are available in a corret was.
You contradict yourself with this demand:

Either you consider that blender isn't installed and having unversioned
requires will be enought to bring the lastest blender release, either blender
is already installed despite not up2date, and we chances are hight that the
LuxRender-blender files will never be copied to the end-user directory anyway.

As a consequence, using a versioned requires will introduce another problem:
LuxRender works pretty well with blender version < 2.48a.
I would like to avoid the introduction of other problem.

> - Why you add an Req rom the devel-docs package to the main
>   Package.
Thx for having noticed, I've removed it

> - Please moveove content of the %doc stanza of the libs subpackage
>   to the main package
The original
> - Rpmlint complaints on binary RPMs:
> pmlint LuxRender-*
> LuxRender.x86_64: W: no-documentation
> LuxRender-blender.x86_64: W: no-documentation
> LuxRender-blender.x86_64: E: wrong-script-interpreter
> /usr/share/blender/scripts/LuxBlend_0.1.py "BPY"
> OK.: Blender specific
> LuxRender-blender.x86_64: E: non-executable-script
> /usr/share/blender/scripts/LuxBlend_0.1.py 0644
> Should be fixed.
Not necessarily, it depends upon the said script is meant to be sourced or
executed directly.If you look at /usr/lib64/python*/, you will see that very
few files are set +x (probably by misstake actually)

> LuxRender-blender.x86_64: E: wrong-script-end-of-line-encoding
> /usr/share/blender/scripts/LuxBlend_0.1.py
> Should be fixed.
Fixed, thx for having noticed.


Upload in Progress...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.