[Bug 500492] Review Request: dbus-cxx - C++ wrapper for dbus

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=500492


Jochen Schmitt <jochen at herr-schmitt.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jochen at herr-schmitt.de
         AssignedTo|nobody at fedoraproject.org    |jochen at herr-schmitt.de
               Flag|                            |fedora-review?




--- Comment #1 from Jochen Schmitt <jochen at herr-schmitt.de>  2009-05-13 15:01:18 EDT ---
Good:
+ Basename of the SPEC files matches with Package name
+ Package name fullfill the naming guidelines
+ Package has proper License tag
+ License tag exclaims GPLv3 as a valid OSS license
+ Source files has GPLv3 copyright note in the header
+ Package contains verbatin text of the license
+ URL tag shows on proper project home page
+ consistently usage of rpm macros
+ Package contains most recent version of the application
+ Could download upstream source tar ball via spectool -g
+ Package source tar ball matches with upstream
/md5sum: 028c2acd8f551ea9d68cc6b01c668b41 )
+ Package contains several subpackages
+ Subpackages has proper RPM group
+ Package has proper Buildroot defintion
+ Buildroot will be cleaned on the beginning of %clean and %install
+ Package has SMP build
+ Local build works fine
+ Build honors RPM_OPt_FLAGS
+ Rpmlint is silent on source rpm
+ Rpmlint complaints
$ rpmlint dbus-cxx-tools-0.1.0-1.fc10.x86_64.rpm
dbus-cxx-tools.x86_64: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
This is acceeptable
+ Rpmlint is silent on debuginfo file
+ Debuginfo rpm contains sources
+ Local install and uninstall works fine
+ Package has proper ldconfig scriptlets
+ Packaged files has proper files properties
+ %files stanza contains no duplicates files
+ Packaged files are own by the package
+ Packaged files has no conflict with ohter packages
+ Devel package contains no *.la or *.a files
+ Package has proper %Changelog stanza

Bad:
- %doc stanza on devel subpackage seem to be large,
  It will be nice to have a extra subpackage for it
- Scratch build on koji fails 
  http://koji.fedoraproject.org/koji/taskinfo?taskID=1353480

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.