[Bug 487114] Review Request: gvrpcd - A program for announcing VLANs using GVRP.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487114


Jeroen van Meeuwen <kanarip at kanarip.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kanarip at kanarip.com




--- Comment #13 from Jeroen van Meeuwen <kanarip at kanarip.com>  2009-05-13 15:10:03 EDT ---
(In reply to comment #11)
> (In reply to comment #10)
> > * A proper exit(..) call at end of main() would eliminate the following
> > compiler warning:
> > gvrpcd.c:290: warning: control reaches end of non-void function
> > 
> > 
> I don't know C, if this is a blocker, could you propose a patch? Alternatively,
> I could ask upstream for a patch, but I think it'd be nicer if we just come up
> with the patch.
> 

Handed Jasper a patch adding a line

    exit(do_shutdown);

to the end of main(). do_shutdown is the signal value gvrpcd uses to indicate
what type of signal it got telling it to terminate so that's what I'm using
here.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.